> On 2011-10-29 03:32:13, David Capwell wrote: > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java, > > line 42 > > <https://reviews.apache.org/r/2582/diff/1/?file=53678#file53678line42> > > > > hbase.client.scanner.caching is the value used in hbase. can you > > switch to hcat.hbase.client.scanner.caching? > >
I think I will open another JIRA for this. As francis suggested, it makes tracking easier. > On 2011-10-29 03:32:13, David Capwell wrote: > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java, > > line 90 > > <https://reviews.apache.org/r/2582/diff/1/?file=53679#file53679line90> > > > > Maybe change your variable to be a HBaseSerDeResultConverter so you > > don't have to do any casting. > > Francis Liu wrote: > in this case I would update the interface with the new method. The result converter has a new method in it. > On 2011-10-29 03:32:13, David Capwell wrote: > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java, > > line 269 > > <https://reviews.apache.org/r/2582/diff/1/?file=53680#file53680line269> > > > > Why is this needed? Now I have changed it to access the method through the HBaseSerDe class itself. > On 2011-10-29 03:32:13, David Capwell wrote: > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java, > > line 289 > > <https://reviews.apache.org/r/2582/diff/1/?file=53680#file53680line289> > > > > Is it always index 0? What if my mapping is cf:,:key? Thanks for correcting. I have made the changes. - Vandana ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2582/#review2921 ----------------------------------------------------------- On 2011-10-26 22:54:36, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2582/ > ----------------------------------------------------------- > > (Updated 2011-10-26 22:54:36) > > > Review request for hcatalog, Francis Liu and David Capwell. > > > Summary > ------- > > The current input storage driver for HBase does not use columns of the output > schema for projection. The output columns should be used to read only those > specific columns from HBase. > > > This addresses bug hcatalog-143. > https://issues.apache.org/jira/browse/hcatalog-143 > > > Diffs > ----- > > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java > 1182480 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java > 1182480 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java > 1182480 > > /trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java > 1182480 > > Diff: https://reviews.apache.org/r/2582/diff > > > Testing > ------- > > Unit test updates and test passes. > > > Thanks, > > Vandana > >
