----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2582/#review2914 -----------------------------------------------------------
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java <https://reviews.apache.org/r/2582/#comment6512> Is this value arbitrary? What is HBase's default? /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java <https://reviews.apache.org/r/2582/#comment6513> in the future, unrelated changes should be in a separate jira. things are clearer that way. /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java <https://reviews.apache.org/r/2582/#comment6515> you don't need to suppress the warning if you access the static method via HBaseSerde instead of the object instance. /trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java <https://reviews.apache.org/r/2582/#comment6618> remove dead code - Francis On 2011-10-26 22:54:36, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2582/ > ----------------------------------------------------------- > > (Updated 2011-10-26 22:54:36) > > > Review request for hcatalog, Francis Liu and David Capwell. > > > Summary > ------- > > The current input storage driver for HBase does not use columns of the output > schema for projection. The output columns should be used to read only those > specific columns from HBase. > > > This addresses bug hcatalog-143. > https://issues.apache.org/jira/browse/hcatalog-143 > > > Diffs > ----- > > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java > 1182480 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java > 1182480 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java > 1182480 > > /trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java > 1182480 > > Diff: https://reviews.apache.org/r/2582/diff > > > Testing > ------- > > Unit test updates and test passes. > > > Thanks, > > Vandana > >
