[
https://issues.apache.org/jira/browse/HCATALOG-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139075#comment-13139075
]
[email protected] commented on HCATALOG-143:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2582/#review2921
-----------------------------------------------------------
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java
<https://reviews.apache.org/r/2582/#comment6537>
hbase.client.scanner.caching is the value used in hbase. can you switch to
hcat.hbase.client.scanner.caching?
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java
<https://reviews.apache.org/r/2582/#comment6538>
Maybe change your variable to be a HBaseSerDeResultConverter so you don't
have to do any casting.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java
<https://reviews.apache.org/r/2582/#comment6539>
Why not handle errors? If an error happens it should be handled or sent up
the chain.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java
<https://reviews.apache.org/r/2582/#comment6542>
Why is this needed?
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java
<https://reviews.apache.org/r/2582/#comment6540>
Is it always index 0? What if my mapping is cf:,:key?
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java
<https://reviews.apache.org/r/2582/#comment6541>
Should change to throw the whole exception.
- David
On 2011-10-26 22:54:36, Vandana Ayyalasomayajula wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2582/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-26 22:54:36)
bq.
bq.
bq. Review request for hcatalog, Francis Liu and David Capwell.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The current input storage driver for HBase does not use columns of the
output schema for projection. The output columns should be used to read only
those specific columns from HBase.
bq.
bq.
bq. This addresses bug hcatalog-143.
bq. https://issues.apache.org/jira/browse/hcatalog-143
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java
1182480
bq.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java
1182480
bq.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java
1182480
bq.
/trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java
1182480
bq.
bq. Diff: https://reviews.apache.org/r/2582/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit test updates and test passes.
bq.
bq.
bq. Thanks,
bq.
bq. Vandana
bq.
bq.
> Pushing projection columns into HBase scans
> --------------------------------------------
>
> Key: HCATALOG-143
> URL: https://issues.apache.org/jira/browse/HCATALOG-143
> Project: HCatalog
> Issue Type: Improvement
> Affects Versions: 0.3
> Reporter: Vandana Ayyalasomayajula
> Assignee: Vandana Ayyalasomayajula
> Labels: hbase, storage_drivers
> Fix For: 0.3
>
> Attachments: HCATALOG-143.patch
>
>
> The current input storage driver for HBase does not use columns of the output
> schema for projection. The output columns should be used to read only those
> specific columns from HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
