[ 
https://issues.apache.org/jira/browse/HCATALOG-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140446#comment-13140446
 ] 

[email protected] commented on HCATALOG-143:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2582/#review2914
-----------------------------------------------------------



/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java
<https://reviews.apache.org/r/2582/#comment6512>

    Is this value arbitrary? What is HBase's default?
    



/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java
<https://reviews.apache.org/r/2582/#comment6513>

    in the future, unrelated changes should be in a separate jira. things are 
clearer that way.



/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java
<https://reviews.apache.org/r/2582/#comment6515>

    you don't need to suppress the warning if you access the static method via 
HBaseSerde instead of the object instance.



/trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java
<https://reviews.apache.org/r/2582/#comment6618>

    remove dead code


- Francis


On 2011-10-26 22:54:36, Vandana Ayyalasomayajula wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2582/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-26 22:54:36)
bq.  
bq.  
bq.  Review request for hcatalog, Francis Liu and David Capwell.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The current input storage driver for HBase does not use columns of the 
output schema for projection. The output columns should be used to read only 
those specific columns from HBase.
bq.  
bq.  
bq.  This addresses bug hcatalog-143.
bq.      https://issues.apache.org/jira/browse/hcatalog-143
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java
 1182480 
bq.    
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java
 1182480 
bq.    
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java
 1182480 
bq.    
/trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java
 1182480 
bq.  
bq.  Diff: https://reviews.apache.org/r/2582/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Unit test updates and test passes. 
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Vandana
bq.  
bq.


                
> Pushing projection columns into HBase scans 
> --------------------------------------------
>
>                 Key: HCATALOG-143
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-143
>             Project: HCatalog
>          Issue Type: Improvement
>    Affects Versions: 0.3
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Vandana Ayyalasomayajula
>              Labels: hbase, storage_drivers
>             Fix For: 0.3
>
>         Attachments: HCATALOG-143.patch
>
>
> The current input storage driver for HBase does not use columns of the output 
> schema for projection. The output columns should be used to read only those 
> specific columns from HBase.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to