[
https://issues.apache.org/jira/browse/HCATALOG-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140697#comment-13140697
]
[email protected] commented on HCATALOG-143:
--------------------------------------------------------
bq. On 2011-10-29 03:32:13, David Capwell wrote:
bq. >
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java,
line 42
bq. > <https://reviews.apache.org/r/2582/diff/1/?file=53678#file53678line42>
bq. >
bq. > hbase.client.scanner.caching is the value used in hbase. can you
switch to hcat.hbase.client.scanner.caching?
bq. >
I think I will open another JIRA for this. As francis suggested, it makes
tracking easier.
bq. On 2011-10-29 03:32:13, David Capwell wrote:
bq. >
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java,
line 90
bq. > <https://reviews.apache.org/r/2582/diff/1/?file=53679#file53679line90>
bq. >
bq. > Maybe change your variable to be a HBaseSerDeResultConverter so you
don't have to do any casting.
bq.
bq. Francis Liu wrote:
bq. in this case I would update the interface with the new method.
The result converter has a new method in it.
bq. On 2011-10-29 03:32:13, David Capwell wrote:
bq. >
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java,
line 269
bq. > <https://reviews.apache.org/r/2582/diff/1/?file=53680#file53680line269>
bq. >
bq. > Why is this needed?
Now I have changed it to access the method through the HBaseSerDe class itself.
bq. On 2011-10-29 03:32:13, David Capwell wrote:
bq. >
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java,
line 289
bq. > <https://reviews.apache.org/r/2582/diff/1/?file=53680#file53680line289>
bq. >
bq. > Is it always index 0? What if my mapping is cf:,:key?
Thanks for correcting. I have made the changes.
- Vandana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2582/#review2921
-----------------------------------------------------------
On 2011-10-26 22:54:36, Vandana Ayyalasomayajula wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2582/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-26 22:54:36)
bq.
bq.
bq. Review request for hcatalog, Francis Liu and David Capwell.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The current input storage driver for HBase does not use columns of the
output schema for projection. The output columns should be used to read only
those specific columns from HBase.
bq.
bq.
bq. This addresses bug hcatalog-143.
bq. https://issues.apache.org/jira/browse/hcatalog-143
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java
1182480
bq.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java
1182480
bq.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java
1182480
bq.
/trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java
1182480
bq.
bq. Diff: https://reviews.apache.org/r/2582/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit test updates and test passes.
bq.
bq.
bq. Thanks,
bq.
bq. Vandana
bq.
bq.
> Pushing projection columns into HBase scans
> --------------------------------------------
>
> Key: HCATALOG-143
> URL: https://issues.apache.org/jira/browse/HCATALOG-143
> Project: HCatalog
> Issue Type: Improvement
> Affects Versions: 0.3
> Reporter: Vandana Ayyalasomayajula
> Assignee: Vandana Ayyalasomayajula
> Labels: hbase, storage_drivers
> Fix For: 0.3
>
> Attachments: HCATALOG-143.patch
>
>
> The current input storage driver for HBase does not use columns of the output
> schema for projection. The output columns should be used to read only those
> specific columns from HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
