> On 2012-01-18 17:55:23, Vandana Ayyalasomayajula wrote: > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java, > > line 116 > > <https://reviews.apache.org/r/3291/diff/2/?file=69524#file69524line116> > > > > You might have to add a check to see if the revision manager instance > > is null.
The only time this might return a null is if "RevisionManagerFactory.getRevisionManager(properties)" returns null. And if it does I believe that would be a bug? > On 2012-01-18 17:55:23, Vandana Ayyalasomayajula wrote: > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java, > > line 63 > > <https://reviews.apache.org/r/3291/diff/2/?file=69530#file69530line63> > > > > Is there any specific reason why this constant has been moved here from > > HBaseConstants ? This property is no longer exposed to the user. Hence I moved it to a place where it more "local". - Francis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3291/#review4438 ----------------------------------------------------------- On 2012-01-18 06:13:50, Francis Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3291/ > ----------------------------------------------------------- > > (Updated 2012-01-18 06:13:50) > > > Review request for hcatalog, Ashutosh Chauhan, Vandana Ayyalasomayajula, and > David Capwell. > > > Summary > ------- > > Integrated write transactions in HBase OSD. > > > This addresses bug hcatalog-192. > https://issues.apache.org/jira/browse/hcatalog-192 > > > Diffs > ----- > > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java > 8ba0e8a > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputFormat.java > 004e3df > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputStorageDriver.java > bdc06ce > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java > b3b90ab > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseDirectOutputFormat.java > 706c911 > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java > 99b92b1 > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java > 5eac5b8 > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java > 57b4928 > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputStorageDriver.java > b7182fd > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseSerDeResultConverter.java > d6215ed > > Diff: https://reviews.apache.org/r/3291/diff > > > Testing > ------- > > Updated units tests, also had to remove two that were no longer needed. All > tests passed. > > > Thanks, > > Francis > >
