> On 2012-01-18 23:26:10, David Capwell wrote: > > I don't see any integration tests between write to read. Can we add one so > > we know that what the write path does matches with the read?
e2e Test is covering that see HCATALOG-219. Would that be enough? - Francis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3291/#review4455 ----------------------------------------------------------- On 2012-01-18 06:13:50, Francis Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3291/ > ----------------------------------------------------------- > > (Updated 2012-01-18 06:13:50) > > > Review request for hcatalog, Ashutosh Chauhan, Vandana Ayyalasomayajula, and > David Capwell. > > > Summary > ------- > > Integrated write transactions in HBase OSD. > > > This addresses bug hcatalog-192. > https://issues.apache.org/jira/browse/hcatalog-192 > > > Diffs > ----- > > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java > 8ba0e8a > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputFormat.java > 004e3df > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputStorageDriver.java > bdc06ce > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java > b3b90ab > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseDirectOutputFormat.java > 706c911 > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java > 99b92b1 > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java > 5eac5b8 > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java > 57b4928 > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputStorageDriver.java > b7182fd > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseSerDeResultConverter.java > d6215ed > > Diff: https://reviews.apache.org/r/3291/diff > > > Testing > ------- > > Updated units tests, also had to remove two that were no longer needed. All > tests passed. > > > Thanks, > > Francis > >
