[
https://issues.apache.org/jira/browse/HCATALOG-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204757#comment-13204757
]
[email protected] commented on HCATALOG-241:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3819/#review4977
-----------------------------------------------------------
/trunk/src/java/org/apache/hcatalog/data/HCatRecord.java
<https://reviews.apache.org/r/3819/#comment10931>
you be comparing this. you're breaking the transitivity contract for the
compareTo method
/trunk/src/java/org/apache/hcatalog/data/HCatRecord.java
<https://reviews.apache.org/r/3819/#comment10932>
I would argue that we shouldn't be implementing this since we incomplete
knowledge of the users's data. Any comparisons needed internally should be done
via a comparator. Same goes with compareTo
/trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
<https://reviews.apache.org/r/3819/#comment10933>
If memory serves assertions are disabled at runtime by default since it's
supposed to be a testing/debugging tool. This check seems good enough to be an
if condition?
/trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java
<https://reviews.apache.org/r/3819/#comment10935>
I'm a bit lost here the comments and implementation seem to be meant for
the previous experimental implementnation? Maybe we can clean some of these up?
/trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java
<https://reviews.apache.org/r/3819/#comment10936>
shouldn't this be called deserializeField?
/trunk/src/java/org/apache/hcatalog/data/HCatRecordable.java
<https://reviews.apache.org/r/3819/#comment10934>
it would be nice if we didn't have to throw checked exception but runtime
exceptions instead for these methods. I have no idea what the user would get
out of catching these exceptions.
- Francis
On 2012-02-09 00:54:29, Sushanth Sowmyan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3819/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-09 00:54:29)
bq.
bq.
bq. Review request for Alan Gates and Francis Liu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Initial upload.
bq.
bq.
bq. This addresses bug HCATALOG-241.
bq. https://issues.apache.org/jira/browse/HCATALOG-241
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1242037
bq. /trunk/src/java/org/apache/hcatalog/data/DefaultHCatRecord.java 1242037
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecord.java 1242037
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
1242037
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1242037
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordable.java 1242037
bq. /trunk/src/java/org/apache/hcatalog/data/LazyHCatRecord.java
PRE-CREATION
bq. /trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java
1242037
bq.
bq. Diff: https://reviews.apache.org/r/3819/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sushanth
bq.
bq.
> Changes to HCatRecord to support switch from StorageDriver to SerDe
> -------------------------------------------------------------------
>
> Key: HCATALOG-241
> URL: https://issues.apache.org/jira/browse/HCATALOG-241
> Project: HCatalog
> Issue Type: Sub-task
> Affects Versions: 0.4
> Reporter: Alan Gates
> Assignee: Sushanth Sowmyan
> Fix For: 0.4
>
> Attachments: HCATALOG-241.patch
>
>
> This JIRA tracks changes to HCatRecord. See HCATALOG-237 for details and
> design notes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
