[
https://issues.apache.org/jira/browse/HCATALOG-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204893#comment-13204893
]
[email protected] commented on HCATALOG-241:
--------------------------------------------------------
bq. On 2012-02-09 01:56:49, Alan Gates wrote:
bq. > /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java,
line 51
bq. > <https://reviews.apache.org/r/3819/diff/1/?file=73306#file73306line51>
bq. >
bq. > This is a significant behavioral change, to now return null rather
than crash when we can't decode a field. It may be ok, but are we sure? Also,
the log message here should be at least a warn, not a debug which will usually
get ignored.
bq.
bq. Sushanth Sowmyan wrote:
bq. This one is something I had misgivings about, and I'm still a bit
on-the-edge.
bq.
bq. The method we override does not allow throwing an exception, so we
aren't allowed to throw an exception. Earlier, the get method we depended on
wouldn't/couldn't throw an exception. Earlier, we had the objects at hand, and
were only retrieving it. Now, the underlying get can.
bq.
bq. The case where it manifests itself is if the underlying object has
malformed data that causes a deserialization error, and we choose to ignore
that and present nulls to the layers above. I'm not sure I like the hiding
behaviour myself.
bq.
bq. Francis Liu wrote:
bq. Just my 2 cents. Silent errors are bad, mysql has them and adds a lot
of overhead while debugging. This failure is obviously not recoverable since
your gonna give an inconsistent view of the row. So why not throw
IllegalStateException instead?
bq.
bq. Sushanth Sowmyan wrote:
bq. That's an idea - I don't know enough about IllegalStateException
itself, but is it throwable when exceptions themselves aren't declared as
having been throwable? Another possibility is to throw an Error or a Throwable
that gets around that requirement. Does IllegalStateException work that way?
Will experiment.
Yes, you don't need to declare "throws", IllegalStateException extends
RuntimeException, anything that extends RuntimeException is an unchecked
exception.
- Francis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3819/#review4951
-----------------------------------------------------------
On 2012-02-09 00:54:29, Sushanth Sowmyan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3819/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-09 00:54:29)
bq.
bq.
bq. Review request for Alan Gates and Francis Liu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Initial upload.
bq.
bq.
bq. This addresses bug HCATALOG-241.
bq. https://issues.apache.org/jira/browse/HCATALOG-241
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1242037
bq. /trunk/src/java/org/apache/hcatalog/data/DefaultHCatRecord.java 1242037
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecord.java 1242037
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
1242037
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1242037
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordable.java 1242037
bq. /trunk/src/java/org/apache/hcatalog/data/LazyHCatRecord.java
PRE-CREATION
bq. /trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java
1242037
bq.
bq. Diff: https://reviews.apache.org/r/3819/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sushanth
bq.
bq.
> Changes to HCatRecord to support switch from StorageDriver to SerDe
> -------------------------------------------------------------------
>
> Key: HCATALOG-241
> URL: https://issues.apache.org/jira/browse/HCATALOG-241
> Project: HCatalog
> Issue Type: Sub-task
> Affects Versions: 0.4
> Reporter: Alan Gates
> Assignee: Sushanth Sowmyan
> Fix For: 0.4
>
> Attachments: HCATALOG-241.patch
>
>
> This JIRA tracks changes to HCatRecord. See HCATALOG-237 for details and
> design notes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
