[
https://issues.apache.org/jira/browse/HCATALOG-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209063#comment-13209063
]
[email protected] commented on HCATALOG-245:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3846/
-----------------------------------------------------------
(Updated 2012-02-16 01:49:22.772361)
Review request for hcatalog.
Changes
-------
Incorporated review suggestions by Ashutosh. Changes are:
- removed the checks that are already satisfied by Hive's
Driver.doAuthorization()
- moved checks for createTable/createDatabase and addPartition to their
respective SemanticAnalyzerHooks.
- broken the patch into two parts hdfs, and hbase. HBase patch will be
uploaded in a sub issue
- renamed DelegationAuthorizationProvider to better named
StorageDelegationAuthorizationProvider.
- added some more tests.
Summary
-------
As per the design in the parent issue, we will delegate the authorization
checks to the storage handler (hdfs is considered as a storage handler as
well). This jira will introduce HiveAuthorizationProviders for hbase + hdfs.
This addresses bug HCATALOG-245.
https://issues.apache.org/jira/browse/HCATALOG-245
Diffs (updated)
-----
src/java/org/apache/hcatalog/cli/SemanticAnalysis/AddPartitionHook.java
efbb79a
src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateDatabaseHook.java
109de31
src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java
098a06b
src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
8387d8e
src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java
PRE-CREATION
src/java/org/apache/hcatalog/common/AuthUtils.java 7cba8dc
src/java/org/apache/hcatalog/security/HdfsAuthorizationProvider.java
PRE-CREATION
src/java/org/apache/hcatalog/security/StorageDelegationAuthorizationProvider.java
PRE-CREATION
src/test/org/apache/hcatalog/HcatTestUtils.java PRE-CREATION
src/test/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java 64bde1b
src/test/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java.broken
PRE-CREATION
src/test/org/apache/hcatalog/security/TestHdfsAuthorizationProvider.java
PRE-CREATION
Diff: https://reviews.apache.org/r/3846/diff
Testing
-------
Thanks,
enis
> StorageHandler authorization providers
> ---------------------------------------
>
> Key: HCATALOG-245
> URL: https://issues.apache.org/jira/browse/HCATALOG-245
> Project: HCatalog
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: hcat-auth_v1.patch
>
>
> As per the design in the parent issue, we will delegate the authorization
> checks to the storage handler (hdfs is considered as a storage handler as
> well). This jira will introduce HiveAuthorizationProviders for hbase + hdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
