[
https://issues.apache.org/jira/browse/HCATALOG-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209946#comment-13209946
]
[email protected] commented on HCATALOG-245:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3846/#review5175
-----------------------------------------------------------
src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java
<https://reviews.apache.org/r/3846/#comment11340>
We should probably add a comment in here that checks are not done currently
for storage-handler based tables.
src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
<https://reviews.apache.org/r/3846/#comment11331>
Looks like this switch statement is no longer of any value now. Can this be
removed?
src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
<https://reviews.apache.org/r/3846/#comment11336>
This could potentially be an issue when table has lots of partitions in it.
This will generate many listStatus call on NN in short time. Not sure if there
is a way around that though.
src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
<https://reviews.apache.org/r/3846/#comment11337>
This needs a comment because Hcat require different kind of privileges then
Hive for alter table. We should document what are our checks and where are they
diff from Hive's.
src/java/org/apache/hcatalog/security/StorageDelegationAuthorizationProvider.java
<https://reviews.apache.org/r/3846/#comment11349>
Do we need to put class name of this class as a default value in
conf/proto-hive-site.xml for authprovider conf value?
src/test/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java.broken
<https://reviews.apache.org/r/3846/#comment11341>
Did you rename this file to disable the tests? You can just add name of
this file in src/test/excluded-tests to exclude it, instead of renaming it.
- Ashutosh
On 2012-02-16 22:49:20, enis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3846/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-16 22:49:20)
bq.
bq.
bq. Review request for hcatalog.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As per the design in the parent issue, we will delegate the authorization
checks to the storage handler (hdfs is considered as a storage handler as
well). This jira will introduce HiveAuthorizationProviders for hbase + hdfs.
bq.
bq.
bq. This addresses bug HCATALOG-245.
bq. https://issues.apache.org/jira/browse/HCATALOG-245
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/org/apache/hcatalog/cli/SemanticAnalysis/AddPartitionHook.java
efbb79a
bq.
src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateDatabaseHook.java
109de31
bq. src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java
098a06b
bq.
src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
8387d8e
bq.
src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java
PRE-CREATION
bq. src/java/org/apache/hcatalog/common/AuthUtils.java 7cba8dc
bq. src/java/org/apache/hcatalog/security/HdfsAuthorizationProvider.java
PRE-CREATION
bq.
src/java/org/apache/hcatalog/security/StorageDelegationAuthorizationProvider.java
PRE-CREATION
bq. src/test/org/apache/hcatalog/HcatTestUtils.java PRE-CREATION
bq. src/test/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java 64bde1b
bq. src/test/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java.broken
PRE-CREATION
bq. src/test/org/apache/hcatalog/security/TestHdfsAuthorizationProvider.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3846/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. enis
bq.
bq.
> StorageHandler authorization providers
> ---------------------------------------
>
> Key: HCATALOG-245
> URL: https://issues.apache.org/jira/browse/HCATALOG-245
> Project: HCatalog
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: hcat-auth_v1.patch
>
>
> As per the design in the parent issue, we will delegate the authorization
> checks to the storage handler (hdfs is considered as a storage handler as
> well). This jira will introduce HiveAuthorizationProviders for hbase + hdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
