[
https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290146#comment-14290146
]
Andrew Wang commented on HDFS-7411:
-----------------------------------
Thanks again for reviewing Colin, fixed with the following notes:
bq. Grammar: "is already decomissioning"
"decommissioning in progress" is a state for a node, so I think this is
accurate, although ugly, language.
bq. What's the rationale for initializing the DecomissionManager configuration
in activate rather than in the constructor? It seems like if we initialized the
conf stuff in the constructor we could make more of it final?
I wasn't sure about this either, but it seems like the NN really likes for
everything to be init'd with the Configuration passed when starting common
services.
For this particular function, I went ahead and made the config variables final
since they're just scoped to that function. Since we make a new Monitor each
time, those members are final there too.
> Refactor and improve decommissioning logic into DecommissionManager
> -------------------------------------------------------------------
>
> Key: HDFS-7411
> URL: https://issues.apache.org/jira/browse/HDFS-7411
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch,
> hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch,
> hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch
>
>
> Would be nice to split out decommission logic from DatanodeManager to
> DecommissionManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
