[
https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294345#comment-14294345
]
Andrew Wang commented on HDFS-7411:
-----------------------------------
Hi Nicholas,
Those methods you mentioned are pretty small, and are far from the bulk of the
patch. Would really prefer not to patch split at this point, since it's a lot
of work. Two other reviewers have also made it through this successfully patch,
so I don't think it's so bad to review.
Regarding the removed config property, this is something discussed above. I
don't see a way of deprecating this gracefully, since the units of the old and
new config properties are incompatible. We needed to change the units because
limiting by # of nodes is quite erratic. Since it is quite erratic, I don't
think there's much harm in just removing the old config. It doesn't do much
right now, and with the patch it'll do nothing.
I can move the test method over as you suggested, but would prefer to get
clarity on the above before posting another patch rev. Thanks.
> Refactor and improve decommissioning logic into DecommissionManager
> -------------------------------------------------------------------
>
> Key: HDFS-7411
> URL: https://issues.apache.org/jira/browse/HDFS-7411
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch,
> hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch,
> hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch,
> hdfs-7411.009.patch
>
>
> Would be nice to split out decommission logic from DatanodeManager to
> DecommissionManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
