[
https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290173#comment-14290173
]
Andrew Wang commented on HDFS-7411:
-----------------------------------
If you look at version 2 of the patch, you can see the initial refactor, which
consisted of moving some methods from BlockManager to DecomManager. I didn't
bother splitting this though since it ended up not being very interesting.
DecomManager is also basically all new code, so the old code would be moved and
then subsequently deleted if we split it.
I think the easiest way of reviewing it is just to read through DecomManager,
which really isn't that big of a class. It's quite well commented and has lots
of logging, which is part of why this change as a whole appears large.
> Refactor and improve decommissioning logic into DecommissionManager
> -------------------------------------------------------------------
>
> Key: HDFS-7411
> URL: https://issues.apache.org/jira/browse/HDFS-7411
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch,
> hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch,
> hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch
>
>
> Would be nice to split out decommission logic from DatanodeManager to
> DecommissionManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
