[ 
https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299158#comment-14299158
 ] 

Andrew Wang commented on HDFS-7411:
-----------------------------------

I split the logging changes off to HDFS-7706 which I just committed. New rev 
posted.

bq. It seems the discussion above did not consider the incompatibility. I guess 
the unnecessarily complicated and large patch did hide the important details. 
We need to revisit it.

This statement is false. Configuration compatibility was the core of the above 
discussion. In fact, my 003 rev of this patch tried to keep compatibility with 
the old key, and based on the discussion we decided to change that.

This newest rev does bring fallback support for the old key though, which 
satisfies your comment.

> Refactor and improve decommissioning logic into DecommissionManager
> -------------------------------------------------------------------
>
>                 Key: HDFS-7411
>                 URL: https://issues.apache.org/jira/browse/HDFS-7411
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.5.1
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch, 
> hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch, 
> hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch, 
> hdfs-7411.009.patch, hdfs-7411.010.patch
>
>
> Would be nice to split out decommission logic from DatanodeManager to 
> DecommissionManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to