[
https://issues.apache.org/jira/browse/HDFS-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309776#comment-14309776
]
Jing Zhao commented on HDFS-7716:
---------------------------------
Thanks for the review, Zhe!
bq. Just to clarify, the plan is to commit the updated BlockInfo and
BlockReplicationInfo classes to trunk right?
Yes. A patch has already submitted to HDFS-7743.
bq. If we do want this sanity check, how about BlockInfoStriped,
BlockInfoStripedUnderConstruction, BlockInfoContiguous (or BlockInfoReplicated)?
Actually I do not think we need that sanity check since the current code
already does the conversion before the check. But I think the class names you
proposed look better than BlockReplicationInfo and BlockGroupInfo. I will make
this change in HDFS-7743.
{code}
BlockInfo info = (BlockInfo)triplets[index*3+1];
assert info == null ||
info.getClass().getName().startsWith(BlockInfo.class.getName()) :
"BlockInfo is expected at " + index*3;
{code}
bq. I guess this JIRA requires it to handled reports of striped blocks
Yes, that's why my current patch does not include this part of logic. We can
commit HDFS-7652 first.
> Erasure Coding: extend BlockInfo to handle EC info
> --------------------------------------------------
>
> Key: HDFS-7716
> URL: https://issues.apache.org/jira/browse/HDFS-7716
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-7716.000.patch
>
>
> The current BlockInfo's implementation only supports the replication
> mechanism. To use the same blocksMap handling block group and its data/parity
> blocks, we need to define a new BlockGroupInfo class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
