[
https://issues.apache.org/jira/browse/HDFS-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315200#comment-14315200
]
Zhe Zhang commented on HDFS-7716:
---------------------------------
I finished reviewing the whole patch. It overall looks great and I'm learning a
lot in the reviewing process. This is a big piece and thanks Jing again for the
heavy lifting.
# {{BlockCollection}} seems a clean rebase. I guess there will be a follow-on
JIRA to extend it to support {{BlockInfoStriped}}? Conceptually, I guess the
getters can just return {{BlockInfo}} and let the callers determine the
concrete type?
# Comparing the {{replaceBlock}} logic in {{BlockInfoContiguous}} and
{{BlockInfoStriped}}: it seems {{BlockInfoStriped#replaceBlock}} also handles
cloning the storage locations, while the callers of
{{BlockInfoContiguous#replaceBlock}} already took care of it before calling.
Maybe we should revisit this when {{BlockInfoStripedUnderConstruction}} is in
and {{replaceBlock}} is really called.
# Do you think {{ReplicaUnderConstruction}} needs to distinguish between
contiguous and striped forms? If not, should we move
{{ReplicaUnderConstruction}} class in trunk, as part of the {{BlockInfo}}
refactor?
# Is the plan to check the type of {{lastBlock}} and have separate logic to
handle contiguous and striped blocks?
{code}
- BlockInfoContiguous lastBlock = bc.getLastBlock();
+ BlockInfo lastBlock = bc.getLastBlock();
{code}
# {{FSImageFormatPBSnapshot}} has an empty TODO
# Just to confirm: changes on {{INodeFile}} are just code formatting right?
+1 pending the above questions.
> Erasure Coding: extend BlockInfo to handle EC info
> --------------------------------------------------
>
> Key: HDFS-7716
> URL: https://issues.apache.org/jira/browse/HDFS-7716
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-7716.000.patch, HDFS-7716.001.patch,
> HDFS-7716.002.patch
>
>
> The current BlockInfo's implementation only supports the replication
> mechanism. To use the same blocksMap handling block group and its data/parity
> blocks, we need to define a new BlockGroupInfo class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
