[ 
https://issues.apache.org/jira/browse/HDFS-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487949#comment-14487949
 ] 

Colin Patrick McCabe commented on HDFS-7993:
--------------------------------------------

Thanks for taking a look at this, [~andreina].

{code}
/100 6619 bytes, 1 block(s): Under replicated 
BP-1926123874-10.19.92.116-1428408820198:blk_1073741829_1005. Target Replicas 
is 3 but found 1 replica(s).
0. BP-1926123874-10.19.92.116-1428408820198:blk_1073741829_1005 len=6619 repl=1 
[DatanodeInfoWithStorage[10.19.92.116:50010,DS-13faa414-cf01-4ae7-b307-2ae87caa273c,DISK](LIVE
 Replica), 
DatanodeInfoWithStorage[10.19.92.114:50010,DS-583ffc24-075f-4ad1-913b-45fe0f8a9c82,DISK](DECOMMISSIONING
 Replica)]
{code}

Hmm. We don't need to keep printing "DatanodeInfoWithStorage" for each replica, 
and we should print "LIVE" instead of "LIVE replica", etc.  I think separating 
the fields with slashes might help make this parseable as well.  Maybe it would 
look kind of like this:

{code}
/100 6619 bytes, 1 block(s): Under replicated 
BP-1926123874-10.19.92.116-1428408820198:blk_1073741829_1005. Target Replicas 
is 3 but found 1 replica(s).
0. BP-1926123874-10.19.92.116-1428408820198:blk_1073741829_1005 len=6619 repl=1 
[LIVE/10.19.92.116:50010/DS-13faa414-cf01-4ae7-b307-2ae87caa273c, 
DECOMMISSIONING/10.19.92.114:50010/DS-583ffc24-075f-4ad1-913b-45fe0f8a9c82]
{code}

Looks good aside from that.

> Incorrect descriptions in fsck when nodes are decommissioned
> ------------------------------------------------------------
>
>                 Key: HDFS-7993
>                 URL: https://issues.apache.org/jira/browse/HDFS-7993
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Ming Ma
>            Assignee: J.Andreina
>         Attachments: HDFS-7993.1.patch, HDFS-7993.2.patch
>
>
> When you run fsck with "-files" or "-racks", you will get something like 
> below if one of the replicas is decommissioned.
> {noformat}
> blk_x len=y repl=3 [dn1, dn2, dn3, dn4]
> {noformat}
> That is because in NamenodeFsck, the repl count comes from live replicas 
> count; while the actual nodes come from LocatedBlock which include 
> decommissioned nodes.
> Another issue in NamenodeFsck is BlockPlacementPolicy's verifyBlockPlacement 
> verifies LocatedBlock that includes decommissioned nodes. However, it seems 
> better to exclude the decommissioned nodes in the verification; just like how 
> fsck excludes decommissioned nodes when it check for under replicated blocks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to