[ 
https://issues.apache.org/jira/browse/HDFS-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493729#comment-14493729
 ] 

Vinayakumar B commented on HDFS-7993:
-------------------------------------

patch needs rebase after HDFS-7933.
bq. Change from report.append(" repl=" + liveReplicas); to report.append(" 
repl=" + totalReplicas); 
In the current output, {{blk_x len=y repl=3 \[dn1, dn2, dn3, dn4\]}}, the count 
{{repl=3}} exactly gives the count of live replicas excluding 
decommission(ing/ed). So i think leaving it as is would be better.

bq. Instead of using DatanodeInfo to find replica details, we can use 
NumberReplicas instead. 
As discussed above, this jira is to add the detail/state about each replica, 
not just the overall count, which is not available in {{NumberReplicas}}.

bq. If we need to count "stale datanode", we can add another field to 
NumberReplicas for that.
I think this count will be there for long time, since the block report interval 
is long. IMO If necessary may go in followup jira


> Incorrect descriptions in fsck when nodes are decommissioned
> ------------------------------------------------------------
>
>                 Key: HDFS-7993
>                 URL: https://issues.apache.org/jira/browse/HDFS-7993
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Ming Ma
>            Assignee: J.Andreina
>         Attachments: HDFS-7993.1.patch, HDFS-7993.2.patch
>
>
> When you run fsck with "-files" or "-racks", you will get something like 
> below if one of the replicas is decommissioned.
> {noformat}
> blk_x len=y repl=3 [dn1, dn2, dn3, dn4]
> {noformat}
> That is because in NamenodeFsck, the repl count comes from live replicas 
> count; while the actual nodes come from LocatedBlock which include 
> decommissioned nodes.
> Another issue in NamenodeFsck is BlockPlacementPolicy's verifyBlockPlacement 
> verifies LocatedBlock that includes decommissioned nodes. However, it seems 
> better to exclude the decommissioned nodes in the verification; just like how 
> fsck excludes decommissioned nodes when it check for under replicated blocks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to