[
https://issues.apache.org/jira/browse/HDFS-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14496627#comment-14496627
]
Zhe Zhang commented on HDFS-7949:
---------------------------------
Thanks Rakesh for the update!
bq. Also, updated the hard-coded assert value.
What I meant in the previous review was to remove this hard-coded number
{{13107200}} and use something like the below instead:
{code}
long expected = BlockInfoStriped.spaceConsumed(xxx);
// use expected in assertion
{code}
I just noticed that {{spaceConsumed}} needs to be updated too. Please see the
latest patch under HDFS-8120. We should call
{{StripedBlockUtil#getInternalBlockLength}} to calculate size of parity blocks.
I think that patch will be committed soon. Maybe we should wait for that and
then move the static {{spaceConsumed}} method to there?
Thanks for the good work on this JIRA and sorry about the back and forth.
> WebImageViewer need support file size calculation with striped blocks
> ---------------------------------------------------------------------
>
> Key: HDFS-7949
> URL: https://issues.apache.org/jira/browse/HDFS-7949
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Hui Zheng
> Assignee: Rakesh R
> Priority: Minor
> Attachments: HDFS-7949-001.patch, HDFS-7949-002.patch,
> HDFS-7949-003.patch, HDFS-7949-004.patch
>
>
> The file size calculation should be changed when the blocks of the file are
> striped in WebImageViewer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
