[ 
https://issues.apache.org/jira/browse/HDFS-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497646#comment-14497646
 ] 

Rakesh R commented on HDFS-7949:
--------------------------------

Thanks [~zhz] for the review.
bq. Maybe we should wait for that and then move the static {{spaceConsumed}} 
method to there?
IIUC your suggestion is to move the {{#spaceConsumed}} function to 
{{StripedBlockUtil}} utility, isn't it?

Thanks [~drankye] for the review.
bq. below codes, the assertion isn't clear to me.
For assertion, I'm using {{fileStatus.toString()}} representation which 
contains {{length}} attribute info. Now, its hard coded value. As per the 
[~zhz] suggestion, I will update using {{#spaceConsumed}} function directly. 
Does this sound good to you?

> WebImageViewer need support file size calculation with striped blocks
> ---------------------------------------------------------------------
>
>                 Key: HDFS-7949
>                 URL: https://issues.apache.org/jira/browse/HDFS-7949
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Hui Zheng
>            Assignee: Rakesh R
>            Priority: Minor
>         Attachments: HDFS-7949-001.patch, HDFS-7949-002.patch, 
> HDFS-7949-003.patch, HDFS-7949-004.patch
>
>
> The file size calculation should be changed when the blocks of the file are 
> striped in WebImageViewer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to