[
https://issues.apache.org/jira/browse/HDFS-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511884#comment-14511884
]
Zhe Zhang commented on HDFS-7949:
---------------------------------
Thanks Rakesh for the updated patch; The overall logic looks pretty good to me.
The main concern now is that the new {{spaceConsumed}} method seems to work for
a set of striped block groups. This is ambiguous and probably won't work
correctly because {{getInternalBlockLength}} works for a single internal block.
For example, if {{numDataBlkBytes}} is equal to 2 cells, it could mean a single
data block with size of 2 cells or 2 data blocks each as large as a cell.
How about changing {{spaceConsumed}} to {{spaceConsumedByStripedBlock}} (which
works for a single striped block group)? The body of the method in
{{StripedBlockUtil}} doesn't need to be changed; the main change will be in
{{FSImageLoader}} I guess.
> WebImageViewer need support file size calculation with striped blocks
> ---------------------------------------------------------------------
>
> Key: HDFS-7949
> URL: https://issues.apache.org/jira/browse/HDFS-7949
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Hui Zheng
> Assignee: Rakesh R
> Priority: Minor
> Attachments: HDFS-7949-001.patch, HDFS-7949-002.patch,
> HDFS-7949-003.patch, HDFS-7949-004.patch, HDFS-7949-005.patch,
> HDFS-7949-006.patch
>
>
> The file size calculation should be changed when the blocks of the file are
> striped in WebImageViewer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
