[
https://issues.apache.org/jira/browse/HDFS-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498938#comment-14498938
]
Zhe Zhang commented on HDFS-8146:
---------------------------------
Thanks Uma for starting the work! The patch looks good overall. A couple of
issues worth discussing:
# When these EC recovery data structures were developed under HDFS-7369 we had
a [discussion |
https://issues.apache.org/jira/browse/HDFS-7369?focusedCommentId=14366760&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14366760]
about whether to use 2D arrays. In this patch, are 2D arrays used in
{{BlockECRecoveryCommand}} to simplify PB translation?
# Similarly, should we use a {{DatanodeStorageInfo}} to represent each target?
But that requires adding PB support for {{DatanodeStorageInfo}} itself..
> Protobuf changes for BlockECRecoveryCommand and its fields for making it
> ready for transfer to DN
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-8146
> URL: https://issues.apache.org/jira/browse/HDFS-8146
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-8146.0.patch
>
>
> As part of working on HDFS-8137, we need to prepare BlockECRecoveryCommand,
> BlockECRecoveryInfo, DatanodeStorageInfo, DatanodeDescripter (We can use
> DatanodeInfo for proto trasfer) should be ready in proto format for
> transferring them in command. Since all this code could be straight forward
> and to have better focussed review on core part, I propose to separate this
> part in to this JIRA. First I will prepare all this supported classes
> protobuf ready and then trasnfer them to DN as part of HDFS-8137 by including
> ECSchema.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
