[
https://issues.apache.org/jira/browse/HDFS-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501399#comment-14501399
]
Vinayakumar B commented on HDFS-8146:
-------------------------------------
Changes looks good [~umamaheswararao].
I have some doubts.
1. Whether really {{targetStorageIDs}} will be used while recovering the block?
Currently BlockCommand's targetStorageIDs are not used otherthan in tests.
2. {{final static int DNA_ERASURE_CODE = 11; // erasure coding recovery
command}} whether this is enough for the recovery command.? What if name it as
{{DNA_ERASURE_CODE_RECOVERY}} ?
Later if fresh conversions also included in same command then we can rename it
back to {{DNA_ERASURE_CODE}} without changing its value. Sounds good?
> Protobuf changes for BlockECRecoveryCommand and its fields for making it
> ready for transfer to DN
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-8146
> URL: https://issues.apache.org/jira/browse/HDFS-8146
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-8146-1.patch, HDFS-8146.0.patch
>
>
> As part of working on HDFS-8137, we need to prepare BlockECRecoveryCommand,
> BlockECRecoveryInfo, DatanodeStorageInfo, DatanodeDescripter (We can use
> DatanodeInfo for proto trasfer) should be ready in proto format for
> transferring them in command. Since all this code could be straight forward
> and to have better focussed review on core part, I propose to separate this
> part in to this JIRA. First I will prepare all this supported classes
> protobuf ready and then trasnfer them to DN as part of HDFS-8137 by including
> ECSchema.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
