[ 
https://issues.apache.org/jira/browse/HDFS-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500380#comment-14500380
 ] 

Zhe Zhang commented on HDFS-8146:
---------------------------------

Thanks Uma. Either option looks fine to me. 

Another possible code optimization is to add PB support for {{BlockTargetPair}} 
and use it to PB'ficate both {{BlockCommand}} and {{BlockECRecoveryCommand}}. 

> Protobuf changes for BlockECRecoveryCommand and its fields for making it 
> ready for transfer to DN 
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8146
>                 URL: https://issues.apache.org/jira/browse/HDFS-8146
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-8146.0.patch
>
>
> As part of working on HDFS-8137, we need to prepare BlockECRecoveryCommand, 
> BlockECRecoveryInfo, DatanodeStorageInfo, DatanodeDescripter (We can use 
> DatanodeInfo for proto trasfer)  should be ready in proto format for 
> transferring them in command. Since all this code could be straight forward 
> and to have better focussed review on core part, I propose to separate this 
> part in to this JIRA. First I will prepare all this supported classes 
> protobuf ready and then trasnfer them to DN as part of HDFS-8137 by including 
> ECSchema.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to