[ 
https://issues.apache.org/jira/browse/HDFS-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506985#comment-14506985
 ] 

Yi Liu commented on HDFS-8024:
------------------------------

The patch is good to me, the {{ErasureCodingWorker}} contains some basic 
information, I will add more in the striped block recovery patch.
One nit:
{quote}
  RawErasureCoder createRawEncoder = null;
  RawErasureCoder createRawDecoder = null;
{quote}
The name looks strange, could you rename it to {{rawEncoder}} and 
{{rawDecoder}}?

> Erasure Coding: ECworker frame, basics, bootstraping and configuration
> ----------------------------------------------------------------------
>
>                 Key: HDFS-8024
>                 URL: https://issues.apache.org/jira/browse/HDFS-8024
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-8024-0.patch
>
>
> This is to come up ECWorker itself, considering its basic setup, 
> configuration and bootstrapping, which will be used to frame all the related 
> work together, like BlockGroup, coding work, block reader, writer and etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to