[ 
https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507983#comment-14507983
 ] 

Plamen Jeliazkov commented on HDFS-8217:
----------------------------------------

Hi [~vinayrpet],

Just looked over the work.

My only nit, I see you are changing the style of the LOG.info from String 
concat to StringBuilder. 
It does change the overall style of other LOG.info statements and the two are 
equivalent after compilation so long as the String concat is not within a loop.

Other than that, looks good! Thanks!

> During block recovery for truncate Log new Block Id in case of 
> copy-on-truncate is true.
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-8217
>                 URL: https://issues.apache.org/jira/browse/HDFS-8217
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-8217-01.patch, HDFS-8217-02.patch
>
>
> During the block recovery for the truncate, include the newblock Id in case 
> copy-on-truncate set to true.
> Current log message is just as below.
> {noformat}NameNode at /127.0.0.1:55036 calls 
> recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, 
> targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], 
> newGenerationStamp=1002){noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to