[ 
https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510219#comment-14510219
 ] 

Konstantin Shvachko commented on HDFS-8217:
-------------------------------------------

I think it is fine to ignore AvoidInlineConditionalsCheck.
Automation tools should help improve code, but this one just forces you to 
write bunch of code for a simple LOG message.
+1 on your first version.

> During block recovery for truncate Log new Block Id in case of 
> copy-on-truncate is true.
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-8217
>                 URL: https://issues.apache.org/jira/browse/HDFS-8217
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-8217-01.patch, HDFS-8217-02.patch
>
>
> During the block recovery for the truncate, include the newblock Id in case 
> copy-on-truncate set to true.
> Current log message is just as below.
> {noformat}NameNode at /127.0.0.1:55036 calls 
> recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001, 
> targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]], 
> newGenerationStamp=1002){noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to