[
https://issues.apache.org/jira/browse/HDFS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508512#comment-14508512
]
Vinayakumar B commented on HDFS-8217:
-------------------------------------
Thanks [~zero45] for taking a look at the patch.
bq. My only nit, I see you are changing the style of the LOG.info from String
concat to StringBuilder.
Yes I agree that style is changed. But It depends on how you use while building
big messages and *conditional* messages.
In the first patch (.01.patch) if you see, I followed the earlier approach, but
since I used inline conditional statements I got checkstyle comment from
[~hadoopqa].
And I thought StringBuilder would be better.
> During block recovery for truncate Log new Block Id in case of
> copy-on-truncate is true.
> ----------------------------------------------------------------------------------------
>
> Key: HDFS-8217
> URL: https://issues.apache.org/jira/browse/HDFS-8217
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: Vinayakumar B
> Assignee: Vinayakumar B
> Attachments: HDFS-8217-01.patch, HDFS-8217-02.patch
>
>
> During the block recovery for the truncate, include the newblock Id in case
> copy-on-truncate set to true.
> Current log message is just as below.
> {noformat}NameNode at /127.0.0.1:55036 calls
> recoverBlock(BP-409377067-xx.xx.xx.253-1429679063755:blk_1073741825_1001,
> targets=[DatanodeInfoWithStorage[127.0.0.1:55045,null,null]],
> newGenerationStamp=1002){noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
