[
https://issues.apache.org/jira/browse/HDFS-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537586#comment-14537586
]
Rakesh R commented on HDFS-8294:
--------------------------------
Thank you [~drankye] for the reviews.
bq. 1. It doesn't make much sense to me in the following change. Could you
clarify or refine a little bit?
I referred {{BlockInfoContiguousUnderConstruction#initializeBlockRecovery}}, it
doesn't has the null check. So I was thinking that the {{null}} check is
purposefully added in
{{BlockInfoStripedUnderConstruction#initializeBlockRecovery}}, in that case if
this is null safer to return it rather than removing the check fully.
bq. Maybe we could declare cellSize as long in offsetInBlkToOffsetInBG to
avoid the cast in it?
Yes I agree with you.
bq. Looks like more issues than the description listed were addressed. Would
you update the issue description for better understanding all the changes?
Thanks for pointing out this. yes desc is based on old report. I've attached
the latest one into the jira and modified the description.
In my patch I've done few refactoring to fix the {{Multithreaded correctness
Warnings}}. As per the analysis, the warning has reported mainly due to the
{{streamer}} object reference, which is getting updated during write operation.
The proposed fix is to make the {{#setCurrentStreamer()}} method synchronized
and all the other callers should get the {{streamer}} object through
{{#getStreamer()}} method which is synchronized.
{code}
org.apache.hadoop.hdfs.DFSStripedOutputStream.java
private StripedDataStreamer setCurrentStreamer(int i) {
streamer = streamers.get(i);
return getCurrentStreamer();
}
{code}
> Erasure Coding: Fix Findbug warnings present in erasure coding
> --------------------------------------------------------------
>
> Key: HDFS-8294
> URL: https://issues.apache.org/jira/browse/HDFS-8294
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Rakesh R
> Labels: BB2015-05-RFC
> Attachments: FindBugs Report in EC feature.html,
> HDFS-8294-HDFS-7285.00.patch, HDFS-8294-HDFS-7285.01.patch,
> HDFS-8294-HDFS-7285.02.patch, HDFS-8294-HDFS-7285.03.patch
>
>
> This jira is to address the findbug issues reported in erasure coding feature.
> Attached sheet which contains the details of the findbug issues reported in
> the erasure coding feature. I've taken this report from the jenkins build :
> https://builds.apache.org/job/PreCommit-HDFS-Build/10848/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
