[
https://issues.apache.org/jira/browse/HDFS-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537694#comment-14537694
]
Rakesh R commented on HDFS-8294:
--------------------------------
Thanks again [~drankye]. Truly, I failed to find the need of {{null}} check.
But there may be some reason for this. In a true case where replicas.length is
zero, then presently {{#initializeBlockRecovery()}} function is only setting
the {{primaryNodeIndex = -1;}} and return. In that case, I think changing the
validation and return logic like below one satisfy FindBugs check. Also, this
won't touch {{null}} condition part.
{code}
if (replicas == null || replicas.length == 0) {
NameNode.blockStateChangeLog.warn("BLOCK*" +
" BlockInfoStripedUnderConstruction.initLeaseRecovery:" +
" No blocks found, lease removed.");
// sets primary node index and return.
primaryNodeIndex = -1;
return;
}
{code}
Any thoughts?
> Erasure Coding: Fix Findbug warnings present in erasure coding
> --------------------------------------------------------------
>
> Key: HDFS-8294
> URL: https://issues.apache.org/jira/browse/HDFS-8294
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Rakesh R
> Labels: BB2015-05-RFC
> Attachments: FindBugs Report in EC feature.html,
> HDFS-8294-HDFS-7285.00.patch, HDFS-8294-HDFS-7285.01.patch,
> HDFS-8294-HDFS-7285.02.patch, HDFS-8294-HDFS-7285.03.patch
>
>
> This jira is to address the findbug issues reported in erasure coding feature.
> Attached sheet which contains the details of the findbug issues reported in
> the erasure coding feature. I've taken this report from the jenkins build :
> https://builds.apache.org/job/PreCommit-HDFS-Build/10848/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
