[
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560759#comment-14560759
]
Vinayakumar B commented on HDFS-8116:
-------------------------------------
bq. If RollingWindowManager class uses SLF4j which does not need to wrap logs
in isDebugEnabled(), we should use this consistently to avoid confusion. Should
we remove the check from RollingWindowManager#snapshot?
I agree that it looks good to be constistent, but there are so many other
classes also with this kind of coding.
Do we need to change everywhere to be consistent? or leave as is and take care
in future coding, as there will not be any benefit in performance after change.
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled()
> before LOG.debug()
> -------------------------------------------------------------------------------------------------
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Xiaoyu Yao
> Assignee: Brahma Reddy Battula
> Priority: Trivial
> Labels: BB2015-05-TBR
> Attachments: HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled()
> before LOG.debug()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
