[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

[Xiaoyu Yao (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575605#comment-14575605
 ] 

Xiaoyu Yao commented on HDFS-8116:
----------------------------------

You may also remove the unnecessary empty line. The fix I would expect is:

{code}
  TopWindow window = new TopWindow(windowLenMs);
  Set<String> metricNames = metricMap.keySet();
  LOG.debug("iterating in reported metrics, size={} values={}",
      metricNames.size(), metricNames);
{code}

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8116
>                 URL: https://issues.apache.org/jira/browse/HDFS-8116
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.7.0
>            Reporter: Xiaoyu Yao
>            Assignee: Brahma Reddy Battula
>            Priority: Trivial
>         Attachments: HDFS-8116-002.patch, HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)