[
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560992#comment-14560992
]
Xiaoyu Yao commented on HDFS-8116:
----------------------------------
Just my 2c: I think we should have cleaned it up when switching to SFL4j. If
there are many other classes with the same issue, we can open separate JIRAs
for them. This way, we reduce the long term maintenance overhead and avoid new
contributors following the unnecessary if (isDebugEnabled()) pattern in new
code.
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled()
> before LOG.debug()
> -------------------------------------------------------------------------------------------------
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Xiaoyu Yao
> Assignee: Brahma Reddy Battula
> Priority: Trivial
> Labels: BB2015-05-TBR
> Attachments: HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled()
> before LOG.debug()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
