[
https://issues.apache.org/jira/browse/HDFS-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568906#comment-14568906
]
Rakesh R commented on HDFS-8450:
--------------------------------
Thanks again [~drankye] for the help. I've few clarifications about the
{{FSDirErasureCodingOp#createErasureCodingZone}} function, could you please see
below points:
# {{fsn.checkOperation(OperationCategory.WRITE);}} should be checked after
acquiring the {{fsn.writeLock();}} again, isn't it ? Please refer
[~vinayrpet]'s
[comment|https://issues.apache.org/jira/browse/HDFS-8450?focusedCommentId=14567220&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14567220]
# IMHO below function to be called after acquiring {{fsd.writeLock();}} lock.
Otherwise it will throw exception.
{code}
+ List<XAttr> xAttrs = fsd.ecZoneManager.createErasureCodingZone(
+ src, schema, cellSize);
{code}
> Erasure Coding: Consolidate erasure coding zone related implementation into a
> single class
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-8450
> URL: https://issues.apache.org/jira/browse/HDFS-8450
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HDFS-8450-FYI.patch, HDFS-8450-HDFS-7285-00.patch,
> HDFS-8450-HDFS-7285-01.patch, HDFS-8450-HDFS-7285-02.patch,
> HDFS-8450-HDFS-7285-03.patch, HDFS-8450-HDFS-7285-04.patch,
> HDFS-8450-HDFS-7285-05.patch
>
>
> The idea is to follow the same pattern suggested by HDFS-7416. It is good to
> consolidate all the erasure coding zone related implementations of
> {{FSNamesystem}}. Here, proposing {{FSDirErasureCodingZoneOp}} class to have
> functions to perform related erasure coding zone operations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
