[
https://issues.apache.org/jira/browse/HDFS-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574197#comment-14574197
]
Vinayakumar B commented on HDFS-8450:
-------------------------------------
bq. I referred other FSNamesystem implementations except encryption related
implementaion all other cases checkSuperuserPrivilege function is called only
once. It looks like not consistently followed. It would be good to find best
practise and follow the same. Any suggestions?
Yes, only once {{checkSuperuserPrivilege}} is sufficient. Authorization check
doesnot depend on the FSNamesystem's state, all no need to check again after
acquiring lock.
bq. Vinayakumar B, could you please correct me if am missing anything. Thanks!
Yes, you are right. Anyway, everything in the patch is just moved from existing
code. So nothing induced. Still its a good time to correct :)
> Erasure Coding: Consolidate erasure coding zone related implementation into a
> single class
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-8450
> URL: https://issues.apache.org/jira/browse/HDFS-8450
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HDFS-8450-FYI.patch, HDFS-8450-HDFS-7285-00.patch,
> HDFS-8450-HDFS-7285-01.patch, HDFS-8450-HDFS-7285-02.patch,
> HDFS-8450-HDFS-7285-03.patch, HDFS-8450-HDFS-7285-04.patch,
> HDFS-8450-HDFS-7285-05.patch, HDFS-8450-HDFS-7285-07.patch,
> HDFS-8450-HDFS-7285-08.patch
>
>
> The idea is to follow the same pattern suggested by HDFS-7416. It is good to
> consolidate all the erasure coding zone related implementations of
> {{FSNamesystem}}. Here, proposing {{FSDirErasureCodingZoneOp}} class to have
> functions to perform related erasure coding zone operations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
