[
https://issues.apache.org/jira/browse/HDFS-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569998#comment-14569998
]
Kai Zheng commented on HDFS-8450:
---------------------------------
Thanks Rakesh again for the update! Some minor comments now:
1. Minor, please update the header comment "Helper class to perform erasure
coding zone related operations."
2. In {{createErasureCodingZone}}, checkSuperuserPrivilege, checkOperation and
writeLock were called two times. I'm not very sure about this, maybe
[~vinayrpet] could give a comment?
3. getErasureCodingZoneForPath could be private as internally used? Note no
lock here so it shouldn't be used by outside.
4. In isInErasureCodingZone, no lock and operation check as did in
createErasureCodingZone.
5. Maybe we could have a private function to transform {{src}} to {{iip}}?
> Erasure Coding: Consolidate erasure coding zone related implementation into a
> single class
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-8450
> URL: https://issues.apache.org/jira/browse/HDFS-8450
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HDFS-8450-FYI.patch, HDFS-8450-HDFS-7285-00.patch,
> HDFS-8450-HDFS-7285-01.patch, HDFS-8450-HDFS-7285-02.patch,
> HDFS-8450-HDFS-7285-03.patch, HDFS-8450-HDFS-7285-04.patch,
> HDFS-8450-HDFS-7285-05.patch, HDFS-8450-HDFS-7285-07.patch
>
>
> The idea is to follow the same pattern suggested by HDFS-7416. It is good to
> consolidate all the erasure coding zone related implementations of
> {{FSNamesystem}}. Here, proposing {{FSDirErasureCodingZoneOp}} class to have
> functions to perform related erasure coding zone operations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
