[
https://issues.apache.org/jira/browse/HDFS-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583879#comment-14583879
]
Jing Zhao commented on HDFS-8587:
---------------------------------
Thanks for the fix, Yi! The patch looks good to me. One minor comment: looks
like we do not need to clone the indices here since the whole object triplets
is still empty. We only need to create an index array and fill it with -1.
{code}
+ BlockInfoStriped(BlockInfoStriped from) {
+ super(from);
+ indices = from.indices.clone();
+ schema = from.schema;
}
{code}
> Erasure Coding: fix the copy constructor of BlockInfoStriped and
> BlockInfoContiguous
> ------------------------------------------------------------------------------------
>
> Key: HDFS-8587
> URL: https://issues.apache.org/jira/browse/HDFS-8587
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Yi Liu
> Assignee: Yi Liu
> Attachments: HDFS-8587-HDFS-7285.001.patch
>
>
> {code}
> BlockInfoStriped(BlockInfoStriped b) {
> this(b, b.getSchema());
> this.setBlockCollection(b.getBlockCollection());
> }
> {code}
> {code}
> protected BlockInfoContiguous(BlockInfoContiguous from) {
> this(from, from.getBlockCollection().getPreferredBlockReplication());
> this.triplets = new Object[from.triplets.length];
> this.setBlockCollection(from.getBlockCollection());
> }
> {code}
> We should define a copy constructor in the {{BlockInfo}}, and call it from
> these two {{subclass}}. I also notice a NullPointerException test failure
> of {{TestBlockInfo.testCopyConstructor}} in latest branch which is related to
> this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
