[
https://issues.apache.org/jira/browse/HDFS-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585049#comment-14585049
]
Hadoop QA commented on HDFS-8587:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 19m 36s | Findbugs (version ) appears to
be broken on HDFS-7285. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 37s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 41s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 0m 15s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 39s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 40s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 3m 25s | The patch appears to introduce 4
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 15s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 177m 9s | Tests failed in hadoop-hdfs. |
| | | 223m 56s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| Failed unit tests | hadoop.hdfs.server.namenode.TestFileTruncate |
| | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS |
| | hadoop.hdfs.TestEncryptedTransfer |
| | hadoop.hdfs.server.mover.TestMover |
| | hadoop.hdfs.server.namenode.TestAuditLogs |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12739478/HDFS-8587-HDFS-7285.002.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | HDFS-7285 / 49d5cff |
| Release Audit |
https://builds.apache.org/job/PreCommit-HDFS-Build/11344/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/11344/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11344/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11344/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11344/console |
This message was automatically generated.
> Erasure Coding: fix the copy constructor of BlockInfoStriped and
> BlockInfoContiguous
> ------------------------------------------------------------------------------------
>
> Key: HDFS-8587
> URL: https://issues.apache.org/jira/browse/HDFS-8587
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Yi Liu
> Assignee: Yi Liu
> Attachments: HDFS-8587-HDFS-7285.001.patch,
> HDFS-8587-HDFS-7285.002.patch
>
>
> {code}
> BlockInfoStriped(BlockInfoStriped b) {
> this(b, b.getSchema());
> this.setBlockCollection(b.getBlockCollection());
> }
> {code}
> {code}
> protected BlockInfoContiguous(BlockInfoContiguous from) {
> this(from, from.getBlockCollection().getPreferredBlockReplication());
> this.triplets = new Object[from.triplets.length];
> this.setBlockCollection(from.getBlockCollection());
> }
> {code}
> We should define a copy constructor in the {{BlockInfo}}, and call it from
> these two {{subclass}}. I also notice a NullPointerException test failure
> of {{TestBlockInfo.testCopyConstructor}} in latest branch which is related to
> this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
