[ 
https://issues.apache.org/jira/browse/HDFS-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585412#comment-14585412
 ] 

Yi Liu commented on HDFS-8587:
------------------------------

Thanks Vinay for point out this, sorry I have not noticed that JIRA.   I think 
yes, the two JIRA have some overlap, so it's duplicated, although this JIRA 
changes {{BlockInfo}} and Striped.
I change the assignee to you, since the patch is for latest branch.


> Erasure Coding: fix the copy constructor of BlockInfoStriped and 
> BlockInfoContiguous
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-8587
>                 URL: https://issues.apache.org/jira/browse/HDFS-8587
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: HDFS-8587-HDFS-7285.001.patch, 
> HDFS-8587-HDFS-7285.002.patch
>
>
> {code}
> BlockInfoStriped(BlockInfoStriped b) {
>   this(b, b.getSchema());
>   this.setBlockCollection(b.getBlockCollection());
> }
> {code}
> {code}
> protected BlockInfoContiguous(BlockInfoContiguous from) {
>   this(from, from.getBlockCollection().getPreferredBlockReplication());
>   this.triplets = new Object[from.triplets.length];
>   this.setBlockCollection(from.getBlockCollection());
> }
> {code}
> We should define a copy constructor in the {{BlockInfo}}, and call it from 
> these two {{subclass}}.    I also notice a NullPointerException test failure 
> of {{TestBlockInfo.testCopyConstructor}} in latest branch which is related to 
> this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to