[
https://issues.apache.org/jira/browse/HDFS-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596846#comment-14596846
]
Zhe Zhang commented on HDFS-8619:
---------------------------------
A quick comment is maybe we should consider targeting this for trunk? I haven't
finished reviewing the entire patch, and I see the following changes besides
the main change mentioned above:
# A new {{hasNoDataNodes}} logic.
# A {{Block->BlockInfo}} refactor for {{postponedMisreplicatedBlocks}}.
# Refactor of {{invalidateBlock}} to take counted nodes as input instead of
counting again.
# General code cleanups
All changes LGTM overall, and all look applicable against trunk (except for the
tests).
> Erasure Coding: revisit replica counting for striped blocks
> -----------------------------------------------------------
>
> Key: HDFS-8619
> URL: https://issues.apache.org/jira/browse/HDFS-8619
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-8619.000.patch
>
>
> Currently we use the same {{BlockManager#countNodes}} method for striped
> blocks, which simply treat each internal block as a replica. However, for a
> striped block, we may have more complicated scenario, e.g., we have multiple
> replicas of the first internal block while we miss some other internal
> blocks. Using the current {{countNodes}} methods can lead to wrong decision
> in these scenarios.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
