[
https://issues.apache.org/jira/browse/HDFS-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597131#comment-14597131
]
Tsz Wo Nicholas Sze commented on HDFS-8619:
-------------------------------------------
Patch looks good in general. I agree that we should do most of the changes in
trunk.
- Just a question, why removing the if-condition below? Is the condition
always true?
{code}
//BlockManager.invalidateBlock(..)
- } else if (nr.liveReplicas() >= 1) {
+ } else {
{code}
- Let's move numCorruptReplicas from BlockManager to BlockManagerTestUtil.
- See also if we could move getCorruptReplicaBlockIds from CorruptReplicasMap
to BlockManagerTestUtil or some other class in test.
> Erasure Coding: revisit replica counting for striped blocks
> -----------------------------------------------------------
>
> Key: HDFS-8619
> URL: https://issues.apache.org/jira/browse/HDFS-8619
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-8619.000.patch
>
>
> Currently we use the same {{BlockManager#countNodes}} method for striped
> blocks, which simply treat each internal block as a replica. However, for a
> striped block, we may have more complicated scenario, e.g., we have multiple
> replicas of the first internal block while we miss some other internal
> blocks. Using the current {{countNodes}} methods can lead to wrong decision
> in these scenarios.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
