[ 
https://issues.apache.org/jira/browse/HDFS-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632145#comment-14632145
 ] 

Tsz Wo Nicholas Sze commented on HDFS-8499:
-------------------------------------------

Even for intermediate state, we should choose the best option since the 
intermediate state may last long and possibly becomes the final state.

> ... option A primarily to minimize change and keep trunk more stable ...

This may not be true.  Multiple people told me the design #1 (or the trunk code 
after HDFS-8499) is harder to understand.  Design #2 actually is more closer to 
the trunk code before HDFS-8499.

Ignoring minimizing trunk change for the moment, do you agree that Design #2 is 
better since it uses the strongest is-a relationship for extending?

> Refactor BlockInfo class hierarchy with static helper class
> -----------------------------------------------------------
>
>                 Key: HDFS-8499
>                 URL: https://issues.apache.org/jira/browse/HDFS-8499
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 2.7.0
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>             Fix For: 2.8.0
>
>         Attachments: HDFS-8499.00.patch, HDFS-8499.01.patch, 
> HDFS-8499.02.patch, HDFS-8499.03.patch, HDFS-8499.04.patch, 
> HDFS-8499.05.patch, HDFS-8499.06.patch, HDFS-8499.07.patch, 
> HDFS-8499.UCFeature.patch, HDFS-bistriped.patch
>
>
> In HDFS-7285 branch, the {{BlockInfoUnderConstruction}} interface provides a 
> common abstraction for striped and contiguous UC blocks. This JIRA aims to 
> merge it to trunk.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to