[
https://issues.apache.org/jira/browse/HDFS-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632178#comment-14632178
]
Zhe Zhang commented on HDFS-8499:
---------------------------------
Thank you for sharing those offline feedbacks Nicholas. I don't have a strong
opinion regarding which is-a relationship is stronger and I think it's a subtle
judgment. Not really critical, but if you could share some thoughts on the
comparison it'd be nice. I chose option *A* to avoid breaking the existing is-a
relationship in trunk. I'm OK if you prefer to redo this change with option
*B*, as long as we can avoid duplicate code in the 2 UC classes.
bq. Why there is a circular merging?
The initial intent of HDFS-8487 was only to merge applicable {{BlockInfo}}
changes from HDFS-7285 branch to trunk. I just changed the title to reflect the
broader change it's making. Thanks for pointing it out. Basically I think we
should setup all generic and contiguous {{BlockInfo}} structures under this
umbrella JIRA so HDFS-7285 can only "plug in" the striping counterparts.
> Refactor BlockInfo class hierarchy with static helper class
> -----------------------------------------------------------
>
> Key: HDFS-8499
> URL: https://issues.apache.org/jira/browse/HDFS-8499
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Fix For: 2.8.0
>
> Attachments: HDFS-8499.00.patch, HDFS-8499.01.patch,
> HDFS-8499.02.patch, HDFS-8499.03.patch, HDFS-8499.04.patch,
> HDFS-8499.05.patch, HDFS-8499.06.patch, HDFS-8499.07.patch,
> HDFS-8499.UCFeature.patch, HDFS-bistriped.patch
>
>
> In HDFS-7285 branch, the {{BlockInfoUnderConstruction}} interface provides a
> common abstraction for striped and contiguous UC blocks. This JIRA aims to
> merge it to trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
