[
https://issues.apache.org/jira/browse/HDFS-8909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712563#comment-14712563
]
Walter Su commented on HDFS-8909:
---------------------------------
TestWriteStripedFileWithFailure, TestFileTruncate are not related.
TestFileAppend4 is not related also, it's an issue left over by history, just
didn't show up before.
{code}
static LocatedBlock makeLocatedBlock(FSNamesystem fsn, BlockInfo blk,
//FSDirWriteFileOp.java
DatanodeStorageInfo[] locs, long offset) throws IOException {
LocatedBlock lBlk = BlockManager.newLocatedBlock(fsn.getExtendedBlock(blk),
blk, locs, offset);
{code}
These code leaks BlockInfo to LocatedBlock and causes the TestFileAppend4
fails. The test case injects namenodeRpcServer to dfsclient, so the client will
get the same BlockInfo object. It's not a problem in other cases because
ExtendBlockProto has fewer fields than BlockInfo.
LocatedBlock belongs to {{hadooop-hdfs-client}} project, so BlockInfo should
not appear in LocatedBlock.
I'll appreciate if you could fix this together. Thanks
> Erasure coding: update BlockInfoContiguousUC and BlockInfoStripedUC to use
> BlockUnderConstructionFeature
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-8909
> URL: https://issues.apache.org/jira/browse/HDFS-8909
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS-7285
> Reporter: Zhe Zhang
> Assignee: Jing Zhao
> Attachments: HDFS-8909-HDFS-7285.003.patch, HDFS-8909.000.patch,
> HDFS-8909.001.patch, HDFS-8909.002.patch, HDFS-8909.003.patch
>
>
> HDFS-8801 converts {{BlockInfoUC}} as a feature. We should consolidate
> {{BlockInfoContiguousUC}} and {{BlockInfoStripedUC}} logics to use this
> feature.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
