[
https://issues.apache.org/jira/browse/HDFS-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14714205#comment-14714205
]
Harsh J commented on HDFS-2390:
-------------------------------
bq. + assertEquals("Bandwidth should be a non-negative integer", -1,
exitCode);
This should rather be something like "Negative bandwidth value must fail the
command", such that upon a regression during which the test fails, the message
produced by the JUnit test suite would look like: "Negative bandwidth value
must fail command: expected -1 but got 0".
> dfsadmin -setBalancerBandwidth doesnot validate -ve value
> ---------------------------------------------------------
>
> Key: HDFS-2390
> URL: https://issues.apache.org/jira/browse/HDFS-2390
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer & mover
> Affects Versions: 2.7.1
> Reporter: Rajit Saha
> Assignee: Gautam Gopalakrishnan
> Attachments: HDFS-2390-1.patch, HDFS-2390-2.patch, HDFS-2390-3.patch
>
>
> $ hadoop dfsadmin -setBalancerBandwidth -10000
> does not throw any message that it is invalid although in DN log we are not
> getting
> "DNA_BALANCERBANDWIDTHUPDATE".
> I think it should throw some message that -ve numbers are not valid , as it
> does
> for decimal numbers or non-numbers like -
> $ hadoop dfsadmin -setBalancerBandwidth 12.34
> NumberFormatException: For input string: "12.34"
> Usage: java DFSAdmin [-setBalancerBandwidth <bandwidth in bytes per second>]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
