[
https://issues.apache.org/jira/browse/HDFS-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716463#comment-14716463
]
Harsh J commented on HDFS-2390:
-------------------------------
+1 on v4. The check style warning is about file length, but we can ignore that
(I agree with HADOOP-12005).
The test on the console output does not appear to have failed, and is unrelated
and also passes locally:
{code}
Running org.apache.hadoop.hdfs.server.namenode.TestINodeFile
Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.608 sec -
in org.apache.hadoop.hdfs.server.namenode.TestINodeFile
{code}
Thanks for the test and improvement fix, committing this shortly!
> dfsadmin -setBalancerBandwidth doesnot validate -ve value
> ---------------------------------------------------------
>
> Key: HDFS-2390
> URL: https://issues.apache.org/jira/browse/HDFS-2390
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer & mover
> Affects Versions: 2.7.1
> Reporter: Rajit Saha
> Assignee: Gautam Gopalakrishnan
> Attachments: HDFS-2390-1.patch, HDFS-2390-2.patch, HDFS-2390-3.patch,
> HDFS-2390-4.patch
>
>
> $ hadoop dfsadmin -setBalancerBandwidth -10000
> does not throw any message that it is invalid although in DN log we are not
> getting
> "DNA_BALANCERBANDWIDTHUPDATE".
> I think it should throw some message that -ve numbers are not valid , as it
> does
> for decimal numbers or non-numbers like -
> $ hadoop dfsadmin -setBalancerBandwidth 12.34
> NumberFormatException: For input string: "12.34"
> Usage: java DFSAdmin [-setBalancerBandwidth <bandwidth in bytes per second>]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
