[ 
https://issues.apache.org/jira/browse/HDFS-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716628#comment-14716628
 ] 

Hudson commented on HDFS-2390:
------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #310 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/310/])
HDFS-2390. dfsadmin -setBalancerBandwidth does not validate -ve value. 
Contributed by Gautam Gopalakrishnan. (harsh: rev 
0bf285413f8fcaadbb2d5817fe8090f5fb0d37d9)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdminWithHA.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> dfsadmin -setBalancerBandwidth doesnot validate -ve value
> ---------------------------------------------------------
>
>                 Key: HDFS-2390
>                 URL: https://issues.apache.org/jira/browse/HDFS-2390
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: balancer & mover
>    Affects Versions: 2.7.1
>            Reporter: Rajit Saha
>            Assignee: Gautam Gopalakrishnan
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: HDFS-2390-1.patch, HDFS-2390-2.patch, HDFS-2390-3.patch, 
> HDFS-2390-4.patch
>
>
> $ hadoop dfsadmin -setBalancerBandwidth -10000 
> does not throw any message that it is invalid although in DN log we are not 
> getting
> "DNA_BALANCERBANDWIDTHUPDATE". 
> I think it should throw some message that -ve numbers are not valid , as it 
> does
> for decimal numbers or non-numbers like -
> $ hadoop dfsadmin -setBalancerBandwidth 12.34
> NumberFormatException: For input string: "12.34"
> Usage: java DFSAdmin [-setBalancerBandwidth <bandwidth in bytes per second>]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to