[
https://issues.apache.org/jira/browse/HDFS-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900088#comment-14900088
]
stack commented on HDFS-9080:
-----------------------------
+1
You might add a picture of trace UI showing some traced HDFS ops that can only
happen if up on htrace 4.0 to help with justification for this patch but all
looks good to me.
Suggest you say what these are on commit:
{code}
9 * It would be better if this weren't global, but there are some issues
with
30 * the lifecycle of FileSystem and AbstractFileSystem objects that make
that
31 * impossible.
{code}
In the .md file, you don't close the scope, just the tracer. Do you want to
add a line closing scope?
> update htrace version to 4.0
> ----------------------------
>
> Key: HDFS-9080
> URL: https://issues.apache.org/jira/browse/HDFS-9080
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.8.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-9080.001.patch, HDFS-9080.002.patch,
> HDFS-9080.003.patch, HDFS-9080.004.patch, HDFS-9080.005.patch,
> HDFS-9080.006.patch, HDFS-9080.007.patch, HDFS-9080.009.patch
>
>
> Update the HTrace library version Hadoop uses to htrace 4.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
