[
https://issues.apache.org/jira/browse/HDFS-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903662#comment-14903662
]
Colin Patrick McCabe commented on HDFS-9080:
--------------------------------------------
Thanks for the reviews.
bq. Suggest you say what \[the DFSClient lifecycle issues\] are on commit:
I added a note about HADOOP-6356.
bq. In the .md file, you don't close the scope, just the tracer. Do you want to
add a line closing scope?
So, this is actually an example of the Java 7 "try-with-resources" idiom.
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
I'm going to rework this though, because I'm afraid some people may
misinterpret this code and think that they don't need to close trace scopes.
bq. hdfs-default.xml: This should be fs.client.htrace.sampler.classes.
Fixed, thanks
bq. {{fs.client.htrace.sampler.classes}}... also should be moved to
core-default.xml? FS_CLIENT_HTRACE_PREFIX is defined in
CommonConfigurationKeys.java of hadoop-common
Yes, let's move it to {{core-default.xml}}.
bq. dfs.htrace.spanreceiver.classes is sometimes found in Tracing.md. It should
be fixed as hadoop.htrace.span.receiver.classes.
I added a reference to {{core-default.xml}} so that we don't have to change 2
files next time.
> update htrace version to 4.0
> ----------------------------
>
> Key: HDFS-9080
> URL: https://issues.apache.org/jira/browse/HDFS-9080
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.8.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-9080.001.patch, HDFS-9080.002.patch,
> HDFS-9080.003.patch, HDFS-9080.004.patch, HDFS-9080.005.patch,
> HDFS-9080.006.patch, HDFS-9080.007.patch, HDFS-9080.009.patch,
> tracing-fsshell-put.png
>
>
> Update the HTrace library version Hadoop uses to htrace 4.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
